CC-7056: Add credentials subcommand to containers registries#12693
CC-7056: Add credentials subcommand to containers registries#12693martinezjandrew wants to merge 5 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 5a350fa The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Claude finished @martinezjandrew's task —— View job Changeset ReviewReviewing the changeset file... Tasks:
The changeset Current changeset: ---
"wrangler": minor
---
Add containers registries credentials command for generating temporary push/pull credentials. Only works with the Cloudflare managed registry (registry.cloudflare.com).Issue: The changeset description is minimal and lacks a usage example or additional context that would help users understand how to use this new command. Recommendation: While the version type (minor) is correct for a new command, the description should ideally include:
Suggested improvement: ---
"wrangler": minor
---
Add `wrangler containers registries credentials` command for generating temporary push/pull credentials
You can now generate temporary credentials for pushing and pulling container images to the Cloudflare managed registry:
```bash
wrangler containers registries credentialsThis command only works with the Cloudflare managed registry (registry.cloudflare.com). |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
| push: { | ||
| type: "boolean", | ||
| description: "If you want these credentials to be able to push", | ||
| }, | ||
| pull: { | ||
| type: "boolean", | ||
| description: "If you want these credentials to be able to pull", | ||
| }, |
There was a problem hiding this comment.
should we have a sensible default so its a bit more ergonomic? e.g. it should allow push and pull by default.
| }, | ||
| }); | ||
|
|
||
| export const containersRegistriesCredentialsCommand = createCommand({ |
There was a problem hiding this comment.
it would be great if this could have a json option that outputs this for CI (and has no banners)
|
loving the bug pics |
Fixes #CC-7056.
Add
containers registries credentialscommand, fromcloudchamber registries credentials, for generating temporary push/pull credentials. Only works with the Cloudflare managed registry (registry.cloudflare.com).